[llvm-commits] [llvm] r63940 - /llvm/trunk/include/llvm/Target/TargetRegisterInfo.h

[Evan Cheng]

On Feb 6, 2009, at 10:16 AM, Dan Gohman wrote:

> Wouldn't it be better to make it a pure virtual member function?

Currently most targets don't define and use this though.

Evan

>
>
> Dan
>
> On Feb 6, 2009, at 9:51 AM, Evan Cheng <evan.cheng at apple.com> wrote:
>
>> Author: evancheng
>> Date: Fri Feb  6 11:51:34 2009
>> New Revision: 63940
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=63940&view=rev
>> Log:
>> We don't really need the abort here. This unbreak x86_64 linux build.
>>
>> Modified:
>>   llvm/trunk/include/llvm/Target/TargetRegisterInfo.h
>>
>> Modified: llvm/trunk/include/llvm/Target/TargetRegisterInfo.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetRegisterInfo.h?rev=63940&r1=63939&r2=63940&view=diff
>>
>> ===
>> ===
>> ===
>> =====================================================================
>> --- llvm/trunk/include/llvm/Target/TargetRegisterInfo.h (original)
>> +++ llvm/trunk/include/llvm/Target/TargetRegisterInfo.h Fri Feb  6
>> 11:51:34 2009
>> @@ -426,7 +426,6 @@
>>  /// values.
>>  virtual const TargetRegisterClass *getPointerRegClass() const {
>>    assert(0 && "Target didn't implement getPointerRegClass!");
>> -    abort();
>>    return 0; // Must return a value in order to compile with VS 2005
>>  }
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits