[llvm-commits] [llvm] r61540 - in /llvm/trunk/utils/unittest/googletest: Makefile README.LLVM gtest-all.cc gtest-death-test.cc gtest-internal-inl.h gtest-test-part.cc gtest.cc gtest_main.cc include/gtest/internal/gtest-internal-inl.h

[Misha Brukman]

2009/1/5 John Criswell <criswell at cs.uiuc.edu>

> Misha Brukman wrote:
> > 2009/1/5 John Criswell <criswell at cs.uiuc.edu<mailto:criswell at cs.uiuc.edu
> >>
> > 1) Can you move the copyright/license information to a LICENSE.TXT file
> > and add an entry in llvm/LICENSE.TXT? This is the established convention
> > for third party licenses and makes it easier to find what code has
> > additional licenses.
> >
> > It was already listed in llvm/LICENSE.TXT and referred to the file
> COPYING in this directory, but since you insist, I renamed it to LICENSE.TXT
> .
> >
> Sorry.  I didn't notice the new text in the top level LICENSE.TXT file.
>
> Thanks for renaming the COPYING file.
>
> > 2) The code doesn't compile on my Linux machine. I get the following
> > errors with g++ 4.1.2.<http://4.1.2.>:
> >
> >
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-port.h:327:21:
> > warning: tr1/tuple: No such file or directory
> >
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> > error: 'tr1' is not a member of 'std'
> >
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> > error: 'tr1' is not a member of 'std'
> >
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> > error: template argument 1 is invalid
> >
> > Do you know what the problem might be?
> >
> > Hmm, this might mean we need to run gtest's configure script to let it
> define the pre-processor tokens appropriately.  I'll look into this.
> > FWIW, unittests compile and run fine under gcc 4.1.1, but I don't have
> gcc 4.1.2 installed locally.
> >
> Do you still have access to our research machines?  If so, you should be
> able to log into our newer machines (maute.cs.uiuc.edu and
> gravity.cs.uiuc.edu) and use /usr/bin/g++4.
>

Yes, I do.  I just looked into gtest source code, and it doesn't look like
it needs any preprocessor tokens to get tr1 to work.

I tried using /usr/bin/g++4 on this simple one-line file and it failed to
compile, saying the header wasn't found:

------8<------
#include <tr1/tuple>
------8<------

This tells me that the g++ on your system might not be installed correctly,
because it works for me with gcc-4.1.1 and also because that is the location
of the header in libstdc++:

http://gcc.gnu.org/viewcvs/trunk/libstdc%2B%2B-v3/include/tr1/tuple?view=log

so it might be that this RedHat package was badly configured/installed and
might need to go on the list of "broken versions of GCC" for LLVM.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090105/417ba6fd/attachment.html>