[llvm-commits] [llvm] r61540 - in /llvm/trunk/utils/unittest/googletest: Makefile README.LLVM gtest-all.cc gtest-death-test.cc gtest-internal-inl.h gtest-test-part.cc gtest.cc gtest_main.cc include/gtest/internal/gtest-internal-inl.h

[John Criswell]

Misha Brukman wrote:
> 2009/1/5 John Criswell <criswell at cs.uiuc.edu<mailto:criswell at cs.uiuc.edu>>
> 1) Can you move the copyright/license information to a LICENSE.TXT file
> and add an entry in llvm/LICENSE.TXT? This is the established convention
> for third party licenses and makes it easier to find what code has
> additional licenses.
>
> It was already listed in llvm/LICENSE.TXT and referred to the file COPYING in this directory, but since you insist, I renamed it to LICENSE.TXT .
>   
Sorry.  I didn't notice the new text in the top level LICENSE.TXT file.

Thanks for renaming the COPYING file.

> 2) The code doesn't compile on my Linux machine. I get the following
> errors with g++ 4.1.2.<http://4.1.2.>:
>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-port.h:327:21:
> warning: tr1/tuple: No such file or directory
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> error: 'tr1' is not a member of 'std'
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> error: 'tr1' is not a member of 'std'
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> error: template argument 1 is invalid
>
> Do you know what the problem might be?
>
> Hmm, this might mean we need to run gtest's configure script to let it define the pre-processor tokens appropriately.  I'll look into this.
> FWIW, unittests compile and run fine under gcc 4.1.1, but I don't have gcc 4.1.2 installed locally.
>   
Do you still have access to our research machines?  If so, you should be 
able to log into our newer machines (maute.cs.uiuc.edu and 
gravity.cs.uiuc.edu) and use /usr/bin/g++4.

If you don't have access, I can talk to Vikram and see if he'd be 
willing to re-enable your account. (I imagine he would).  That seems 
like less work than you doing another GCC install on your machines.

-- John T.