[llvm-commits] [llvm] r58718 - /llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp

[Matthijs Kooijman]

Hi Dale,

> > Hi Johannes,
Seems I misinterpreted your login name there :-)

> Right, Chris added the restriction in 55226.  Before that it worked.
Ah, that does explain why the changes I made were needed to get our compiler
on its feet again :-)

> Chris is of the opinion that the restriction ought to be there, so  
> this patch may not stay in place forever.  If you have good arguments  
> for permitting this that would be interesting.
I'm not so sure what is the right approach here, and for our compiler either
way is fine at the moment. However, I feel that removing the restriction makes
sense. I'm not so sure about how vectors work and what other restrictions SROA
imposes, but if a vector is used only in ways that don't interfere with SROA,
then it probably shouldn't have been a vector in the first place. In
particular, if it is used as a vector, and things like vector shuffles and
vector operations are used on it, I think SROA will leave it alone
automatically, right?

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20081105/9028fcc7/attachment.sig>