[llvm-commits] [llvm] r58718 - /llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp

[Dale Johannesen]

On Nov 4, 2008, at 1:27 PMPST, Matthijs Kooijman - Inter-Actief wrote:

> Hi Johannes,
>
>> Allow SROA of vectors.  Removing this caused a
>> huge performance regression in something we care
>> about.  This may not be final fix.
> Good to see this fix. I had intended to work out something like  
> this, but
> never found the time.
>
> However, you're saying "Removing this", but AFAIK SROA of vectors  
> never
> happened? I recently touched this code, but only made the "don't touch
> vectors" limitation slightly less strict, I didn't add it AFAICS?

Right, Chris added the restriction in 55226.  Before that it worked.

Chris is of the opinion that the restriction ought to be there, so  
this patch may not stay in place forever.  If you have good arguments  
for permitting this that would be interesting.