[llvm-commits] [PATCH] align constant pool loads using preferred alignment

[Dan Gohman]

On Sep 17, 2008, at 7:50 AM, Paul Redmond wrote:

> Dan Gohman wrote:
>> I was surprised to see that ConstantPoolSDNode's alignment
>> argument is a log2 value, but that apparently what that
>> code is expecting.
>>
> I made that mistake at first. Perhaps getAlignment can be renamed
> getAlignmentShift?

That seems reasonable. I'm thinking I might see if it's not
too much work to change the code to use a regular alignment
value instead though :-).

>
>> It looks like the code in ScheduleDAGEmit.cpp that handles
>> the alignment==0 case for ConstantPoolSDNode is no longer
>> needed. Does that seem right to you?
>>
> Yes, I believe that can be removed.

Cool, thanks.

Dan