[llvm-commits] [PATCH] align constant pool loads using preferred alignment

Paul Redmond paul at rapidmind.com
Wed Sep 17 07:50:45 PDT 2008


Dan Gohman wrote:
> I was surprised to see that ConstantPoolSDNode's alignment
> argument is a log2 value, but that apparently what that
> code is expecting.
>   
I made that mistake at first. Perhaps getAlignment can be renamed 
getAlignmentShift?
> It looks like the code in ScheduleDAGEmit.cpp that handles
> the alignment==0 case for ConstantPoolSDNode is no longer
> needed. Does that seem right to you?
>   
Yes, I believe that can be removed.

Paul



More information about the llvm-commits mailing list