[llvm-commits] [llvm] r56255 - /llvm/trunk/tools/opt/opt.cpp
Devang Patel
dpatel at apple.com
Wed Sep 17 09:05:41 PDT 2008
On Sep 16, 2008, at 11:20 PM, Duncan Sands wrote:
> Hi Devang,
>
>> + cl::desc("Enable IPO. This is same is llvm-gcc's -
>> funit-at-a-time"));
>
> This is same is -> This is the same as
fixed
>
>> +DisableSimplifyLibCalls("disable-simplify-libcalls",
>> + cl::desc("Disable simplify libcalls"));
>
> The pass name has a hyphen, so how about: Disable simplify-libcalls
ok :)
>
>
>> +/// PruneEH - Add PruneEHPass, if set.
>
> This line can go.
gone
>> +/// UnrollLoop - Unroll loops, if set.
>
> This doesn't seem to exist.
fixed.
> Also, to decrease code duplication, how about:
> (1) have -std-compile-opts call this with -O3 and IPO
> rather than scheduling it's own list of passes,
Feel free.
> (2) stick this in a library somewhere and have llvm-gcc use it too.
I tried. Remember PassManagerUtils.cpp's short lived existence ? :)
This causes circular dependencies, unless you create a separate new
library for just one routine. Feel free to fix this, if you're
inclined to do so. Extra bonus points if you also cover pass sequence
selection from llvm-ld and lto :)
-
Devang
More information about the llvm-commits
mailing list