[llvm-commits] [llvm] r56255 - /llvm/trunk/tools/opt/opt.cpp

[Duncan Sands]

Hi Devang,

> +            cl::desc("Enable IPO. This is same is llvm-gcc's -funit-at-a-time"));

This is same is -> This is the same as


> +DisableSimplifyLibCalls("disable-simplify-libcalls",
> +                        cl::desc("Disable simplify libcalls"));

The pass name has a hyphen, so how about: Disable simplify-libcalls

> +/// PruneEH - Add PruneEHPass, if set.

This line can go.

> +/// UnrollLoop - Unroll loops, if set.

This doesn't seem to exist.

Also, to decrease code duplication, how about:
(1) have -std-compile-opts call this with -O3 and IPO
rather than scheduling it's own list of passes,
(2) stick this in a library somewhere and have llvm-gcc use it too.

Ciao,

Duncan.