[llvm-commits] [llvm] r55893 - in /llvm/trunk: test/CodeGen/X86/fast-isel-phys.ll utils/TableGen/FastISelEmitter.cpp

[Evan Cheng]

Author: evancheng
Date: Mon Sep  8 03:39:33 2008
New Revision: 55893

URL: http://llvm.org/viewvc/llvm-project?rev=55893&view=rev
Log:
Correctly handle physical register inputs. They are not explicit input operands in the resulting machine instrs.

Added:
    llvm/trunk/test/CodeGen/X86/fast-isel-phys.ll
Modified:
    llvm/trunk/utils/TableGen/FastISelEmitter.cpp

Added: llvm/trunk/test/CodeGen/X86/fast-isel-phys.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fast-isel-phys.ll?rev=55893&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/X86/fast-isel-phys.ll (added)
+++ llvm/trunk/test/CodeGen/X86/fast-isel-phys.ll Mon Sep  8 03:39:33 2008
@@ -0,0 +1,11 @@
+; RUN: llvm-as < %s | llc -fast-isel -march=x86
+
+define i8 @t2(i8 %a, i8 %c) nounwind {
+       %tmp = shl i8 %a, %c
+       ret i8 %tmp
+}
+
+define i8 @t1(i8 %a) nounwind {
+       %tmp = mul i8 %a, 17
+       ret i8 %tmp
+}

Modified: llvm/trunk/utils/TableGen/FastISelEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/FastISelEmitter.cpp?rev=55893&r1=55892&r2=55893&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/FastISelEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/FastISelEmitter.cpp Mon Sep  8 03:39:33 2008
@@ -114,7 +114,7 @@
         return false;
       Record *OpLeafRec = OpDI->getDef();
       // For now, the only other thing we accept is register operands.
-      
+
       const CodeGenRegisterClass *RC = 0;
       if (OpLeafRec->isSubClassOf("RegisterClass"))
         RC = &Target.getRegisterClass(OpLeafRec);
@@ -157,21 +157,27 @@
   void PrintArguments(std::ostream &OS,
                       const std::vector<std::string>& PR) const {
     assert(PR.size() == Operands.size());
+    bool PrintedArg = false;
     for (unsigned i = 0, e = Operands.size(); i != e; ++i) {
-      if (PR[i] != "") {
-        OS << PR[i];
-      } else if (Operands[i] == "r") {
+      if (PR[i] != "")
+        // Implicit physical register operand.
+        continue;
+
+      if (PrintedArg)
+        OS << ", ";
+      if (Operands[i] == "r") {
         OS << "Op" << i;
+        PrintedArg = true;
       } else if (Operands[i] == "i") {
         OS << "imm" << i;
+        PrintedArg = true;
       } else if (Operands[i] == "f") {
         OS << "f" << i;
+        PrintedArg = true;
       } else {
         assert("Unknown operand kind!");
         abort();
       }
-      if (i + 1 != e)
-        OS << ", ";
     }
   }
 
@@ -193,6 +199,20 @@
   }
 
 
+  void PrintManglingSuffix(std::ostream &OS,
+                           const std::vector<std::string>& PR) const {
+    for (unsigned i = 0, e = Operands.size(); i != e; ++i) {
+      if (PR[i] != "")
+        // Implicit physical register operand. e.g. Instruction::Mul expect to
+        // select to a binary op. On x86, mul may take a single operand with
+        // the other operand being implicit. We must emit something that looks
+        // like a binary instruction except for the very inner FastEmitInst_*
+        // call.
+        continue;
+      OS << Operands[i];
+    }
+  }
+
   void PrintManglingSuffix(std::ostream &OS) const {
     for (unsigned i = 0, e = Operands.size(); i != e; ++i) {
       OS << Operands[i];
@@ -430,7 +450,7 @@
               
               OS << "  return FastEmitInst_";
               if (Memo.SubRegNo == (unsigned char)~0) {
-                Operands.PrintManglingSuffix(OS);
+                Operands.PrintManglingSuffix(OS, *Memo.PhysRegs);
                 OS << "(" << InstNS << Memo.Name << ", ";
                 OS << InstNS << Memo.RC->getName() << "RegisterClass";
                 if (!Operands.empty())
@@ -497,7 +517,8 @@
           
           // Emit code for each possible instruction. There may be
           // multiple if there are subtarget concerns.
-          for (PredMap::const_iterator PI = PM.begin(), PE = PM.end(); PI != PE; ++PI) {
+          for (PredMap::const_iterator PI = PM.begin(), PE = PM.end(); PI != PE;
+               ++PI) {
             std::string PredicateCheck = PI->first;
             const InstructionMemo &Memo = PI->second;
 
@@ -523,7 +544,7 @@
             OS << "  return FastEmitInst_";
             
             if (Memo.SubRegNo == (unsigned char)~0) {
-              Operands.PrintManglingSuffix(OS);
+              Operands.PrintManglingSuffix(OS, *Memo.PhysRegs);
               OS << "(" << InstNS << Memo.Name << ", ";
               OS << InstNS << Memo.RC->getName() << "RegisterClass";
               if (!Operands.empty())