[llvm-commits] Add eraseFromParent, releaseFromParent to GlobalValue (round 2)

[Chris Lattner]

On Aug 15, 2008, at 11:17 AM, Daniel Dunbar wrote:

>> Looks great to me.  One minor tweak: do you really need a virtual
>
>> method for "erase"?  It should always be "delete removeFromParent()",
>> so you could just put that in the generic GlobalValue case.
>
> Currently eraseFromParent is not "delete removeFromParent()", it is a
> call to erase on the iplist. If this distinction is not important  
> then I
> will drop eraseFromParent from the subclasses.

ilist "erase" is always the same as "remove" + delete, this should be  
safe.

-Chris