[llvm-commits] Add eraseFromParent,	releaseFromParent to GlobalValue (round 2)
    Daniel Dunbar 
    daniel at zuster.org
       
    Fri Aug 15 11:17:37 PDT 2008
    
    
  
> Looks great to me.  One minor tweak: do you really need a virtual  
> method for "erase"?  It should always be "delete removeFromParent()",  
> so you could just put that in the generic GlobalValue case.
Currently eraseFromParent is not "delete removeFromParent()", it is a
call to erase on the iplist. If this distinction is not important then I
will drop eraseFromParent from the subclasses.
 - Daniel
    
    
More information about the llvm-commits
mailing list