[llvm-commits] Add eraseFromParent, releaseFromParent to GlobalValue

[Daniel Dunbar]

> The problem with this patch is that it makes  
> GlobalVariable::eraseFromParent virtual, regardless of whether you put  

> the virtual keyword on it or not.  <snip>

Yes. 

However, GlobalValue already uses virtual methods so I didn't think this 
would be an issue. Will make the change if you want it, but then what
is the justification for not using the pattern for the other virtual methods 
in GlobalValue. I find it hard to believe this is performance critical.

 - Daniel