[llvm-commits] Add eraseFromParent, releaseFromParent to GlobalValue

[Chris Lattner]

On Aug 13, 2008, at 3:02 PM, Daniel Dunbar wrote:

> The attached patch adds (pure virtual)  
> eraseFromParent,releaseFromParent methods
> to GlobalValue.

Hey Daniel,

The problem with this patch is that it makes  
GlobalVariable::eraseFromParent virtual, regardless of whether you put  
the virtual keyword on it or not.  Please follow the pattern used by  
TerminatorInst::getNumSuccessors() to avoid this.  If C++ had a "final  
method" concept like java, we wouldn't need these hacks.

-Chris