[llvm-commits] [llvm] r54228 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAG.h lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp

[Dan Gohman]

Author: djg
Date: Wed Jul 30 13:48:53 2008
New Revision: 54228

URL: http://llvm.org/viewvc/llvm-project?rev=54228&view=rev
Log:
Move SelectionDAG::viewGraph() out of line; as an inline function
it isn't always visible to gdb.

Modified:
    llvm/trunk/include/llvm/CodeGen/SelectionDAG.h
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp

Modified: llvm/trunk/include/llvm/CodeGen/SelectionDAG.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/SelectionDAG.h?rev=54228&r1=54227&r2=54228&view=diff

==============================================================================
--- llvm/trunk/include/llvm/CodeGen/SelectionDAG.h (original)
+++ llvm/trunk/include/llvm/CodeGen/SelectionDAG.h Wed Jul 30 13:48:53 2008
@@ -117,7 +117,7 @@
   /// viewGraph - Pop up a GraphViz/gv window with the DAG rendered using 'dot'.
   ///
   void viewGraph(const std::string &Title);
-  void viewGraph() { return viewGraph(""); }
+  void viewGraph();
   
 #ifndef NDEBUG
   std::map<const SDNode *, std::string> NodeGraphAttrs;

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp?rev=54228&r1=54227&r2=54228&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp Wed Jul 30 13:48:53 2008
@@ -252,6 +252,11 @@
 #endif  // NDEBUG
 }
 
+// This overload is defined out-of-line here instead of just using a
+// default parameter because this is easiest for gdb to call.
+void SelectionDAG::viewGraph() {
+  viewGraph("");
+}
 
 /// clearGraphAttrs - Clear all previously defined node graph attributes.
 /// Intended to be used from a debugging tool (eg. gdb).