[llvm-commits] small bss and data support for elf asm

[Bruno Cardoso Lopes]

On Tue, Jul 22, 2008 at 4:51 AM, Anton Korobeynikov <asl at math.spbu.ru> wrote:
> Hi, Bruno
>
>> +      SmallData,        ///< Small data section
>> +      SmallBSS,         ///< Small bss section
> What's about SmallROData?
>
>> +    const char *SmallDataSection;         // Defaults to NULL
> You don't need these ones currently. Underscored versions were added to
> do transparent migration from old printing mechanism to new. Later const
> char* versions will be dropped.
>
> As no code uses small sections currently, you don't need const char
> versions at all.
>
>> +    const Section *SmallDataSection_;
>> +
>> +    /// SmallBSSSection - This is the directive that is emitted to
>> switch to a
>> +    /// small bss section.
>> +    ///
>> +    const char *SmallBSSSection;          // Defaults to NULL
> Same here.
>
> In general - you're going in right direction, please fix and commit!

done.

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc
"When faced with untenable alternatives, you
 should consider your imperative."