[llvm-commits] small bss and data support for elf asm

Anton Korobeynikov asl at math.spbu.ru
Tue Jul 22 00:51:15 PDT 2008

Hi, Bruno

> +      SmallData,        ///< Small data section
> +      SmallBSS,         ///< Small bss section     
What's about SmallROData?

> +    const char *SmallDataSection;         // Defaults to NULL
You don't need these ones currently. Underscored versions were added to
do transparent migration from old printing mechanism to new. Later const
char* versions will be dropped. 

As no code uses small sections currently, you don't need const char
versions at all.

> +    const Section *SmallDataSection_;
> +
> +    /// SmallBSSSection - This is the directive that is emitted to
> switch to a
> +    /// small bss section.
> +    ///
> +    const char *SmallBSSSection;          // Defaults to NULL
Same here.

In general - you're going in right direction, please fix and commit!

With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.

More information about the llvm-commits mailing list