[llvm-commits] [llvm] r53200 - in /llvm/trunk: include/llvm/CodeGen/MachineMemOperand.h lib/CodeGen/MachineInstr.cpp

[Dan Gohman]

On Jul 8, 2008, at 12:25 AM, Duncan Sands wrote:

> Hi Dan,
>
>> +MachineMemOperand::MachineMemOperand(const Value *v, unsigned int f,
>> +                                     int64_t o, uint64_t s,  
>> unsigned int a)
>> +  : Offset(o), Size(s), V(v),
>> +    Flags((f & 7) | ((Log2_32(a) + 1) << 3)) {
>> +}
>
> if someone (wrongly) passes an alignment of 0, what will happen?
> How about adding an assertion here to catch this case.

Done. It even caught a bug :-).

Thanks,

Dan