[llvm-commits] [llvm] r53200 - in /llvm/trunk: include/llvm/CodeGen/MachineMemOperand.h lib/CodeGen/MachineInstr.cpp

Duncan Sands baldrick at free.fr
Tue Jul 8 00:25:33 PDT 2008


Hi Dan,

> +MachineMemOperand::MachineMemOperand(const Value *v, unsigned int f,
> +                                     int64_t o, uint64_t s, unsigned int a)
> +  : Offset(o), Size(s), V(v),
> +    Flags((f & 7) | ((Log2_32(a) + 1) << 3)) {
> +}

if someone (wrongly) passes an alignment of 0, what will happen?
How about adding an assertion here to catch this case.

Ciao,

Duncan.



More information about the llvm-commits mailing list