[llvm-commits] [llvm] r53146 - in /llvm/trunk/lib/Target/Mips: Mips.td MipsAsmPrinter.cpp MipsCallingConv.td MipsISelDAGToDAG.cpp MipsISelLowering.cpp MipsISelLowering.h MipsInstrFPU.td MipsInstrFormats.td MipsInstrInfo.cpp MipsInstrInfo.h MipsInstrInfo.td MipsMachineFunction.h MipsRegisterInfo.cpp MipsRegisterInfo.td MipsSubtarget.cpp MipsSubtarget.h MipsTargetMachine.cpp

[Chris Lattner]

On Jul 7, 2008, at 8:10 PM, Eric Christopher wrote:

> Couple of questions:
>
> +  if (!Subtarget->isAllegrex()) {
> +    setOperationAction(ISD::SIGN_EXTEND_INREG, MVT::i8, Expand);
> +    setOperationAction(ISD::SIGN_EXTEND_INREG, MVT::i16, Expand);
> +  }
>
> +  bool hasAllegrexVFPU() const { return HasAllegrexVFPU; };
> +  bool isAllegrex() const { return IsAllegrex; };
>
> For these it's probably best to return depending on CPU feature not
> necessarily cpu type. There's a lot of commonality between mips chips.

Great point, it would be best to define these as a subtarget feature  
and then have the cpu table indicate which ones support the feature  
directly.  For an example, please grep for 'FeatureFSqrt' in PPC.td  
for example.

-Chris