[llvm-commits] Slot alignment

[Duncan Sands]

Hi,

> >>  SDOperand SelectionDAG::CreateStackTemporary(MVT VT) {
> >> +  return CreateStackTemporary(VT, 1);
> >
> > while it doesn't hurt to use 1, you could also use 0 here.
> >
> >> +  SDOperand CreateStackTemporary(MVT VT, unsigned minAlign = 1);
> >
> > Here too.
> 
> Alignment of 0 doesn't really make sense.

it is not an alignment, it is a minimum which is never achieved.

> I am not sure I see the benefit of using 0 instead of 1.

The optimizers can eliminate the comparison with the unsigned
quantity Align.  But as I said, it doesn't hurt to use 1.

Ciao,

Duncan.