[llvm-commits] Slot alignment

[Mon P Wang]

Hi,

If I think of it as a maximum of two values where the first value is  
always positive, it indicates
that we use the value of the alignment of VT.  In terms of an  
alignment, it doesn't make any
sense.  Since I called it minAlign, it make more sense to set it to  
one.  I'll fix this.

   -- Mon Ping

On Jul 2, 2008, at 10:36 AM, Evan Cheng wrote:

>
> On Jul 1, 2008, at 11:54 PM, Duncan Sands wrote:
>
>> Hi,
>>
>>> SDOperand SelectionDAG::CreateStackTemporary(MVT VT) {
>>> +  return CreateStackTemporary(VT, 1);
>>
>> while it doesn't hurt to use 1, you could also use 0 here.
>>
>>> +  SDOperand CreateStackTemporary(MVT VT, unsigned minAlign = 1);
>>
>> Here too.
>
> Alignment of 0 doesn't really make sense. I am not sure I see the
> benefit of using 0 instead of 1.
>
> Evan
>
>>
>>
>> Ciao,
>>
>> Duncan.
>>
>> PS: Can you please include patches inline rather than
>> attaching them (if they are not too humungous) - that
>> makes it easier to add comments.  Thanks!
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits