[llvm-commits] [llvm] r52987 - in /llvm/trunk: include/llvm/CodeGen/MachineDebugInfoDesc.h lib/CodeGen/MachineDebugInfoDesc.cpp lib/CodeGen/MachineModuleInfo.cpp

[Chris Lattner]

On Jul 1, 2008, at 11:36 PM, Duncan Sands wrote:

>>>> - Don't use GlobalVariable::LinkageTypes when unsigned works.
>>>
>>> Is there some reason we need this?  I strongly prefer the enum if it
>>> works.
>>> Makes things easier to read and harder to abuse.
>>>
>> It required pulling in the GlobalVariable.h header into the
>> MachineDebugInfoDesc.h file. That's the only reason I can think of.
>
> I'm with Dale here.  How about putting the enum in its own header
> instead?

It would be better to have a debug-info-specific enum value than to  
reuse the one in GlobalValue.  Debug info (like assemblers) don't  
distinguish between linkonce and weak for example.  The producer of  
the debug info should do this "lowering".

-Chris