[llvm-commits] [llvm] r52987 - in /llvm/trunk: include/llvm/CodeGen/MachineDebugInfoDesc.h lib/CodeGen/MachineDebugInfoDesc.cpp lib/CodeGen/MachineModuleInfo.cpp

[Duncan Sands]

> >> - Don't use GlobalVariable::LinkageTypes when unsigned works.
> >
> > Is there some reason we need this?  I strongly prefer the enum if it
> > works.
> > Makes things easier to read and harder to abuse.
> >
> It required pulling in the GlobalVariable.h header into the
> MachineDebugInfoDesc.h file. That's the only reason I can think of.

I'm with Dale here.  How about putting the enum in its own header
instead?

Ciao,

Duncan.