[llvm-commits] [llvm] r52172 - /llvm/trunk/test/lib/llvm.exp

[Tanya Lattner]

For any tests that are failing, can you XFAIL them and then file a  
bug report?

We want to keep make check clean.

Thanks,
Tanya

On Jun 10, 2008, at 5:28 AM, Matthijs Kooijman wrote:

> Author: matthijs
> Date: Tue Jun 10 07:28:43 2008
> New Revision: 52172
>
> URL: http://llvm.org/viewvc/llvm-project?rev=52172&view=rev
> Log:
> Change llvm.exp so it no longer ignores some errors when executing  
> dejagnu
> tests. This breaks 80 tests in the tree.
>
> The interesting part here is that this no longer ignores syntax errors
> in RUN command lines. Some tests have not been working all the time  
> because of
> this.
>
> The tricky part is that it now also views any stderr output as an  
> error. This
> can be suppressed in tcl 8.5, but let's not add this dependency.  
> Instead, all
> testcases should be changed to redirect stderr if they expect  
> stderr output.
> This holds in particular for lines like:
>   ; RUN: not llvm-as < %s
> where an error is expected (but I think I can solve this by  
> modifying the not
> script). Also, compilations resulting in warnings will now also  
> fail (so
> the warnings should be fixed, disabled or redirected...).
>
> I'll continue with fixing the testcases that are broken now.
>
> Modified:
>     llvm/trunk/test/lib/llvm.exp
>
> Modified: llvm/trunk/test/lib/llvm.exp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/lib/ 
> llvm.exp?rev=52172&r1=52171&r2=52172&view=diff
>
> ====================================================================== 
> ========
> --- llvm/trunk/test/lib/llvm.exp (original)
> +++ llvm/trunk/test/lib/llvm.exp Tue Jun 10 07:28:43 2008
> @@ -31,8 +31,12 @@
>          set resultmsg "$test$PRS\nFailed with posix($posixNum, 
> $posixMsg)$errmsg"
>        }
>        NONE {
> +        # Any other error such as stderr output of a program, or  
> syntax error in
> +        # the RUN line.
> +        set resultmsg "$test$PRS\nFailed with unknown error (or  
> has stderr output)$errmsg"
>        }
>        default {
> +        set resultmsg "$test$PRS\nFailed with unknown error$errmsg"
>        }
>      }
>    }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits