[llvm-commits] [llvm] r49610 - in /llvm/trunk/test/Analysis/BasicAA: const-dce.ll pure-const-dce.ll

[Daniel Berlin]

On Mon, Apr 14, 2008 at 4:24 PM, Dan Gohman <gohman at apple.com> wrote:
>
>  On Apr 13, 2008, at 2:51 AM, Owen Anderson wrote:
>
> > Author: resistor
>  > Date: Sun Apr 13 04:51:06 2008
>  > New Revision: 49610
>  >
>  > URL: http://llvm.org/viewvc/llvm-project?rev=49610&view=rev
>  > Log:
>  > The functionality being tested was removed because it was horribly
>  > unsafe.
>
>  It looks like the test was testing that two calls with identical
>  arguments to a readonly function with no intervening stores can
>  be changed to one call. What's horribly unsafe about that?

I don't see anything  unsafe about that either, even though readonly
calls can throw exceptions (since they can only depend on arguments
and global variables, if the first doesn't throw an exception, and
there are no stores/etc, the second can't)