[llvm-commits] [llvm] r49610 - in /llvm/trunk/test/Analysis/BasicAA: const-dce.ll pure-const-dce.ll

[Dan Gohman]

On Apr 13, 2008, at 2:51 AM, Owen Anderson wrote:
> Author: resistor
> Date: Sun Apr 13 04:51:06 2008
> New Revision: 49610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=49610&view=rev
> Log:
> The functionality being tested was removed because it was horribly  
> unsafe.

It looks like the test was testing that two calls with identical
arguments to a readonly function with no intervening stores can
be changed to one call. What's horribly unsafe about that?

Dan

>
> Added:
>    llvm/trunk/test/Analysis/BasicAA/const-dce.ll
>      - copied, changed from r49609, llvm/trunk/test/Analysis/BasicAA/ 
> pure-const-dce.ll
> Removed:
>    llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll
>
> Copied: llvm/trunk/test/Analysis/BasicAA/const-dce.ll (from r49609,  
> llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll)
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/BasicAA/const-dce.ll?p2=llvm/trunk/test/Analysis/BasicAA/const-dce.ll&p1=llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll&r1=49609&r2=49610&rev=49610&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll (original)
> +++ llvm/trunk/test/Analysis/BasicAA/const-dce.ll Sun Apr 13  
> 04:51:06 2008
> @@ -1,5 +1,5 @@
> ; RUN: llvm-as < %s | opt -basicaa -gvn | llvm-dis | grep TestConst  
> | count 2
> -; RUN: llvm-as < %s | opt -basicaa -gvn | llvm-dis | grep TestPure   
> | count 3
> +; RUN: llvm-as < %s | opt -basicaa -gvn | llvm-dis | grep TestPure   
> | count 4
> ; RUN: llvm-as < %s | opt -basicaa -gvn | llvm-dis | grep TestNone   
> | count 4
> @g = global i32 0		; <i32*> [#uses=1]
>
>
> Removed: llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll?rev=49609&view=auto
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll (original)
> +++ llvm/trunk/test/Analysis/BasicAA/pure-const-dce.ll (removed)
> @@ -1,33 +0,0 @@
> -; RUN: llvm-as < %s | opt -basicaa -gvn | llvm-dis | grep TestConst  
> | count 2
> -; RUN: llvm-as < %s | opt -basicaa -gvn | llvm-dis | grep TestPure   
> | count 3
> -; RUN: llvm-as < %s | opt -basicaa -gvn | llvm-dis | grep TestNone   
> | count 4
> - at g = global i32 0		; <i32*> [#uses=1]
> -
> -define i32 @test() {
> -entry:
> -	%tmp0 = call i32 @TestConst( i32 5 ) readnone 		; <i32> [#uses=1]
> -	%tmp1 = call i32 @TestPure( i32 6 ) readonly 		; <i32> [#uses=1]
> -	%tmp2 = call i32 @TestNone( i32 7 )		; <i32> [#uses=1]
> -	store i32 1, i32* @g
> -	%tmp3 = call i32 @TestConst( i32 5 ) readnone 		; <i32> [#uses=1]
> -	%tmp4 = call i32 @TestConst( i32 5 ) readnone 		; <i32> [#uses=1]
> -	%tmp5 = call i32 @TestPure( i32 6 ) readonly 		; <i32> [#uses=1]
> -	%tmp6 = call i32 @TestPure( i32 6 ) readonly 		; <i32> [#uses=1]
> -	%tmp7 = call i32 @TestNone( i32 7 )		; <i32> [#uses=1]
> -	%tmp8 = call i32 @TestNone( i32 7 )		; <i32> [#uses=1]
> -	%sum0 = add i32 %tmp0, %tmp1		; <i32> [#uses=1]
> -	%sum1 = add i32 %sum0, %tmp2		; <i32> [#uses=1]
> -	%sum2 = add i32 %sum1, %tmp3		; <i32> [#uses=1]
> -	%sum3 = add i32 %sum2, %tmp4		; <i32> [#uses=1]
> -	%sum4 = add i32 %sum3, %tmp5		; <i32> [#uses=1]
> -	%sum5 = add i32 %sum4, %tmp6		; <i32> [#uses=1]
> -	%sum6 = add i32 %sum5, %tmp7		; <i32> [#uses=1]
> -	%sum7 = add i32 %sum6, %tmp8		; <i32> [#uses=1]
> -	ret i32 %sum7
> -}
> -
> -declare i32 @TestConst(i32) readnone
> -
> -declare i32 @TestPure(i32) readonly
> -
> -declare i32 @TestNone(i32)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits