[llvm-commits] [llvm] r47862 - /llvm/trunk/lib/CodeGen/MachineInstr.cpp

Evan Cheng evan.cheng at apple.com
Mon Mar 3 16:07:48 PST 2008


Except it's not using an iterator...

Evan

On Mar 3, 2008, at 3:51 PM, Bill Wendling wrote:

> On Mon, Mar 3, 2008 at 3:47 PM, Evan Cheng <evan.cheng at apple.com>  
> wrote:
>> Haven't you heard goto's are evil? :-)
>>
>> I think goto's can be used tastefully. However, it's definitely not
>> the right situation to use it in this case.
>>
> Fair enough. I was 90% sure that that was going to be picked on when I
> submitted it. I did it that way because how the machine operands are
> stored in the machine instruction is non-intuitive and I didn't want
> to make a mistake of having an invalid iterator. :-)
>
> -bw
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list