[llvm-commits] [llvm] r44037 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/SelectionDAG/ lib/Target/ARM/ lib/Target/Alpha/ lib/Target/IA64/ lib/Target/Mips/ lib/Target/PowerPC/ lib/Target/Sparc/ lib/Target/X86/

[Evan Cheng]

On Nov 12, 2007, at 4:44 PM, Bill Wendling wrote:

>
> ====================================================================== 
> ========
> --- llvm/trunk/lib/Target/ARM/ARMInstrInfo.td (original)
> +++ llvm/trunk/lib/Target/ARM/ARMInstrInfo.td Mon Nov 12 18:44:25 2007
> @@ -17,7 +17,9 @@
>  //
>
>  // Type profiles.
> -def SDT_ARMCallSeq : SDTypeProfile<0, 1, [ SDTCisVT<0, i32> ]>;
> +def SDT_ARMCallSeq_start : SDTypeProfile<0, 1, [ SDTCisVT<0, i32> ]>;
> +def SDT_ARMCallSeq_end   : SDTypeProfile<0, 2, [ SDTCisVT<0, i32>,
> +                                                 SDTCisVT<1, i32> ]>;
>
>  def SDT_ARMSaveCallPC : SDTypeProfile<0, 1, []>;
>
> @@ -45,10 +47,10 @@
>  def ARMWrapper       : SDNode<"ARMISD::Wrapper",     SDTIntUnaryOp>;
>  def ARMWrapperJT     : SDNode<"ARMISD::WrapperJT",   SDTIntBinOp>;
>
> -def ARMcallseq_start : SDNode<"ISD::CALLSEQ_START", SDT_ARMCallSeq,
> +def ARMcallseq_start : SDNode<"ISD::CALLSEQ_START",  
> SDT_ARMCallSeq_start,
>      		              [SDNPHasChain, SDNPOutFlag]>;
> -def ARMcallseq_end   : SDNode<"ISD::CALLSEQ_END",   SDT_ARMCallSeq,
> -    		              [SDNPHasChain, SDNPInFlag, SDNPOutFlag]>;
> +def ARMcallseq_end   : SDNode<"ISD::CALLSEQ_END",    
> SDT_ARMCallSeq_end,
> +    		              [SDNPHasChain, SDNPOptInFlag, SDNPOutFlag]>;
>

Please unify these as well by adding callseq_start / callseq_down to  
TargetSelectionDAG.td and use those instead.

Also, where are the test case(s)? :-)

Evan