[llvm-commits] RE [llvm] r43805 - /llvm/trunk/lib/CodeGen/StrongPHIElimination.cpp

[Evan Cheng]

On Nov 6, 2007, at 11:26 PM, Owen Anderson wrote:

> Evan,
>
> I may end up using a BitVector or SparseBitVector in the future.  I  
> was just going with an std::set for simplicity until I'm sure I  
> won't be changing it further.

Ok, but SmallPtrSet and SmallSet behaves just like std::set except  
it's not horribly slow. :-)

>
>
> By the way, could you check that isLiveIn() and isLiveOut() are  
> correctly?  I _think_ I got VarInfo figured out, but I'm not  
> confident.

isLiveIn() looks wrong. I think you just need to check if DefInst is  
in the given MBB, if not than it has to be livein. For isLiveOut(),  
you need to check 1) if it's completely live through, 2) if it is used  
in the MBB and it's not killed.  You may want to add UsedBlocks back  
to VarInfo. I removed it in r36250 because it wasn't being used.

Evan

>
>
> --Owen	_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits