[llvm-commits] CVS: llvm/lib/CodeGen/IfConversion.cpp
evan.cheng at apple.com
Tue May 15 22:09:02 PDT 2007
It shouldn't. :-) I am missing an assert.
This check earlier ensures that the block ends with either a
conditional branch or a conditional branch + a unconditional branch.
if (TII->AnalyzeBranch(*BB, BBI.TBB, BBI.FBB, BBI.Cond)
|| !BBI.TBB || BBI.Cond.size() == 0)
BBI.FBB is only NULL if it's the former.
The comments in TargetInstrInfo.h is incorrect. I'll fix.
On May 15, 2007, at 8:07 PM, Devang Patel wrote:
> On May 15, 2007, at 7:01 PM, Evan Cheng wrote:
>> + if (!BBI.FBB)
>> + BBI.FBB = findFalseBlock(BB, BBI.TBB);
>> + AnalyzeBlock(BBI.FBB);
>> + BBInfo &FBBI = BBAnalysis[BBI.FBB->getNumber()];
> If findFalseBlock returns NULL then AnalyzeBlock may crash here.
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits