<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; ">It shouldn't. :-) I am missing an assert.<DIV><BR class="khtml-block-placeholder"></DIV><DIV>This check earlier ensures that the block ends with either a conditional branch or a conditional branch + a unconditional branch.</DIV><DIV>  if (TII->AnalyzeBranch(*BB, BBI.TBB, BBI.FBB, BBI.Cond)</DIV><DIV>      || !BBI.TBB || BBI.Cond.size() == 0)</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>BBI.FBB is only NULL if it's the former.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>The comments in TargetInstrInfo.h is incorrect. I'll fix.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Thanks,</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Evan</DIV><DIV><BR><DIV><DIV>On May 15, 2007, at 8:07 PM, Devang Patel wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><BR><DIV><DIV>On May 15, 2007, at 7:01 PM, Evan Cheng wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica">+ <SPAN class="Apple-converted-space">  </SPAN>if (!BBI.FBB)</FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica">+ <SPAN class="Apple-converted-space">    </SPAN>BBI.FBB = findFalseBlock(BB, BBI.TBB); <SPAN class="Apple-converted-space"> </SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica">+ <SPAN class="Apple-converted-space">  </SPAN>AnalyzeBlock(BBI.FBB);</FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT face="Helvetica" size="3" style="font: 12.0px Helvetica">+ <SPAN class="Apple-converted-space">  </SPAN>BBInfo &FBBI = BBAnalysis[BBI.FBB->getNumber()];</FONT></DIV> </BLOCKQUOTE></DIV><BR><DIV>If findFalseBlock returns NULL then AnalyzeBlock may crash here.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>-</DIV><DIV>Devang</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">_______________________________________________</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">llvm-commits mailing list</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</A></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</A></DIV> </BLOCKQUOTE></DIV><BR></DIV></BODY></HTML>