[llvm-commits] Message cleanup

[Christopher Lamb]

On Apr 19, 2007, at 1:57 PM, Chris Lattner wrote:

>>>> I see that the patch had the wrong file extension...
>>>
>>> The extension is ok, but the diff looks funky:
>>>
>>>         assert(Boundary && (Boundary & (Boundary - 1)) == 0 &&
>>> -             "Must alitypedef std::vector<unsigned char>
>>> DataBuffer;gn to 2^k boundary");
>>> +             "Must align to 2^k boundary");
>>>         size_t Size = Output.size();
>>>
>>
>> By funky do you mean the line break? It's not in the file I sent,
>> nor in the file as saved on the commits archive site.
>
> Okay, I figured out what is happening.  The code looks like this:
>
>               "Must alitypedef std::vector<unsigned char>
> DataBuffer;gn to 2^k boundary");
>         size_t Size = Output.size();
>
>         if (Size & (Boundary - 1)) {
>           // Add padding to get alignment to the correct place.
>
> The blank line (in CVS) has several spaces in it.  In your patch
> there are no spaces, so the patch doesn't apply.  Is something
> stripping off trailing spaces here?

I had edited the patches in TextMate, which does some whitespace  
stripping in certain instances, apparently. This patch should have  
the needed whitespace.

--
Christopher Lamb



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20070419/d402c2c7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: message_cleanup.diff
Type: application/octet-stream
Size: 1579 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20070419/d402c2c7/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20070419/d402c2c7/attachment-0001.html>