[llvm-commits] Message cleanup

Chris Lattner clattner at apple.com
Thu Apr 19 11:57:53 PDT 2007


>>> I see that the patch had the wrong file extension...
>>
>> The extension is ok, but the diff looks funky:
>>
>>         assert(Boundary && (Boundary & (Boundary - 1)) == 0 &&
>> -             "Must alitypedef std::vector<unsigned char>
>> DataBuffer;gn to 2^k boundary");
>> +             "Must align to 2^k boundary");
>>         size_t Size = Output.size();
>>
>
> By funky do you mean the line break? It's not in the file I sent,  
> nor in the file as saved on the commits archive site.

Okay, I figured out what is happening.  The code looks like this:

              "Must alitypedef std::vector<unsigned char>  
DataBuffer;gn to 2^k boundary");
        size_t Size = Output.size();

        if (Size & (Boundary - 1)) {
          // Add padding to get alignment to the correct place.

The blank line (in CVS) has several spaces in it.  In your patch  
there are no spaces, so the patch doesn't apply.  Is something  
stripping off trailing spaces here?

-Chris




More information about the llvm-commits mailing list