[llvm-commits] CVS: llvm/include/llvm/Support/MathExtras.h

Chris Lattner clattner at apple.com
Sat Mar 24 16:40:03 PDT 2007


On Mar 22, 2007, at 1:18 PM, Reid Spencer wrote:

> On Thu, 2007-03-22 at 12:35 -0700, Jeff Cohen wrote:
>> How is it any worse than checking for GCC?
>
> I don't like that either :)

FWIW, I don't see anything wrong with Jeff's change.  MathExtras may  
be suboptimal w.r.t to libsystem, but so is compiler.h and others.  I  
think it's fine for headers/inline functions to violate the libsystem  
design.

-Chris



More information about the llvm-commits mailing list