[llvm-commits] CVS: llvm/include/llvm/Support/MathExtras.h

Jeff Cohen jeffc at jolt-lang.org
Thu Mar 22 12:45:01 PDT 2007


Reid Spencer wrote:
>
>> -    for (uint64_t Shift = 64 >> 1; Shift; Shift >>= 1) {
>> +    for (unsigned Shift = 64 >> 1; Shift; Shift >>= 1) {
>>     
>
> Why not uint32_t? For conformity with the rest of your changes?

The size of a shift amount is unrelated to the size of the function's 
argument, so there's no reason not to use the "natural" integer size.




More information about the llvm-commits mailing list