[llvm-commits] [llvm-gcc] SETCC Removal Patch (Please Commit)
rspencer at reidspencer.com
Thu Jan 4 09:45:11 PST 2007
On Thu, 2007-01-04 at 09:37 -0800, Chris Lattner wrote:
> On Dec 22, 2006, at 10:08 PM, Reid Spencer wrote:
> > All,
> > As the SetCondInst instruction has been replaced with the new FCmpInst
> > and ICmpInst instrucitons in LLVM, the attached patch compensates for
> > this in llvm-gcc. Since the Apple developers are unlikely to commit
> > this
> > for over a week, if you're working over the holidays you'll need to
> > apply this manually to your llvm-gcc tree.
> This patch is incorrect for many FP comparisons. It looks like
> you've fixed almost all of them in later patches. However LTGT_EXPR
> should be FCMP_ONE, not FCMP_UNE, and that is still in mainline.
This is something that was changed recently because it broke something
for Rafael and he indicates that gcc was doing, essentially an FCMP_UNE.
I thought != was supposed to be UNE while == was supposed to be ONE. You
made that comment to me in a previous review.
In any event, its easy enough to fix.
More information about the llvm-commits