[llvm-commits] [llvm-gcc] SETCC Removal Patch (Please Commit)
clattner at apple.com
Thu Jan 4 09:37:47 PST 2007
On Dec 22, 2006, at 10:08 PM, Reid Spencer wrote:
> As the SetCondInst instruction has been replaced with the new FCmpInst
> and ICmpInst instrucitons in LLVM, the attached patch compensates for
> this in llvm-gcc. Since the Apple developers are unlikely to commit
> for over a week, if you're working over the holidays you'll need to
> apply this manually to your llvm-gcc tree.
This patch is incorrect for many FP comparisons. It looks like
you've fixed almost all of them in later patches. However LTGT_EXPR
should be FCMP_ONE, not FCMP_UNE, and that is still in mainline.
More information about the llvm-commits