[llvm-commits] CVS: llvm/lib/Target/X86/X86ISelPattern.cpp

[Chris Lattner]

Changes in directory llvm/lib/Target/X86:

X86ISelPattern.cpp updated: 1.59 -> 1.60
---
Log message:

Do not fold a load into a comparison that is used by more than one place.
The comparison will probably be folded, so this is not ok to do.
This fixed 197.parser.


---
Diffs of the changes:  (+8 -8)

Index: llvm/lib/Target/X86/X86ISelPattern.cpp
diff -u llvm/lib/Target/X86/X86ISelPattern.cpp:1.59 llvm/lib/Target/X86/X86ISelPattern.cpp:1.60
--- llvm/lib/Target/X86/X86ISelPattern.cpp:1.59	Sun Jan 16 18:23:16 2005
+++ llvm/lib/Target/X86/X86ISelPattern.cpp	Sun Jan 16 19:34:14 2005
@@ -347,7 +347,7 @@
     void EmitFoldedLoad(SDOperand Op, X86AddressMode &AM);
 
 
-    void EmitCMP(SDOperand LHS, SDOperand RHS);
+    void EmitCMP(SDOperand LHS, SDOperand RHS, bool isOnlyUse);
     bool EmitBranchCC(MachineBasicBlock *Dest, SDOperand Chain, SDOperand Cond);
     void EmitSelectCC(SDOperand Cond, MVT::ValueType SVT,
                       unsigned RTrue, unsigned RFalse, unsigned RDest);
@@ -741,7 +741,7 @@
     case ISD::SETUGE: Opc = X86::JAE; break;
     }
     Select(Chain);
-    EmitCMP(SetCC->getOperand(0), SetCC->getOperand(1));
+    EmitCMP(SetCC->getOperand(0), SetCC->getOperand(1), SetCC->hasOneUse());
     BuildMI(BB, Opc, 1).addMBB(Dest);
     return false;
   }
@@ -798,7 +798,7 @@
   }
 
   Select(Chain);
-  EmitCMP(SetCC->getOperand(0), SetCC->getOperand(1));
+  EmitCMP(SetCC->getOperand(0), SetCC->getOperand(1), SetCC->hasOneUse());
   BuildMI(BB, Opc, 1).addMBB(Dest);
   if (Opc2)
     BuildMI(BB, Opc2, 1).addMBB(Dest);
@@ -910,17 +910,17 @@
     }
   } else {
     // FIXME: CMP R, 0 -> TEST R, R
-    EmitCMP(Cond.getOperand(0), Cond.getOperand(1));
+    EmitCMP(Cond.getOperand(0), Cond.getOperand(1), Cond.Val->hasOneUse());
     std::swap(RTrue, RFalse);
   }
   BuildMI(BB, Opc, 2, RDest).addReg(RTrue).addReg(RFalse);
 }
 
-void ISel::EmitCMP(SDOperand LHS, SDOperand RHS) {
+void ISel::EmitCMP(SDOperand LHS, SDOperand RHS, bool HasOneUse) {
   unsigned Opc;
   if (ConstantSDNode *CN = dyn_cast<ConstantSDNode>(RHS)) {
     Opc = 0;
-    if (isFoldableLoad(LHS)) {
+    if (HasOneUse && isFoldableLoad(LHS)) {
       switch (RHS.getValueType()) {
       default: break;
       case MVT::i1:
@@ -959,7 +959,7 @@
   }
 
   Opc = 0;
-  if (isFoldableLoad(LHS)) {
+  if (HasOneUse && isFoldableLoad(LHS)) {
     switch (RHS.getValueType()) {
     default: break;
     case MVT::i1:
@@ -1947,7 +1947,7 @@
     return Result;
 
   case ISD::SETCC:
-    EmitCMP(N.getOperand(0), N.getOperand(1));
+    EmitCMP(N.getOperand(0), N.getOperand(1), Node->hasOneUse());
     EmitSetCC(BB, Result, cast<SetCCSDNode>(N)->getCondition(),
               MVT::isFloatingPoint(N.getOperand(1).getValueType()));
     return Result;