[llvm-bugs] [Bug 51675] [libc++][PowerPC] libcxx/gdb/gdb_pretty_printer_test.sh.cpp LIT test case failure on LLVM 13

via llvm-bugs llvm-bugs at lists.llvm.org
Fri Sep 3 11:57:31 PDT 2021


https://bugs.llvm.org/show_bug.cgi?id=51675

Louis Dionne <ldionne at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |ldionne at apple.com
 Fixed By Commit(s)|                            |1c3fcc8ae92ebfe9a9d1a21a288
                   |                            |ad71ef7f98091
             Status|NEW                         |RESOLVED

--- Comment #11 from Louis Dionne <ldionne at apple.com> ---
Fixed on main and cherry-picked to release/13.x as

commit 1c3fcc8ae92ebfe9a9d1a21a288ad71ef7f98091 (HEAD -> release/13.x)
Author: Amy Kwan <amy.kwan1 at ibm.com>
Date:   Fri Sep 3 14:53:57 2021 -0400

    [libc++][NFC] Mark values in gdb pretty print comparison functions as live
to prevent values being optimized out.

    It appears when testing LLVM 13 on Power, we run into failures with the
    `libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp` test case
optimizing
    values out.

    Despite some the functions in the test already being marked with optnone,
    adding the `MarkAsLive()` calls inside of the pretty printer comparison
functions
    resolves the issues of the values being optimized out.

    This patch aims to address https://llvm.org/PR51675.

    Differential Revision: https://reviews.llvm.org/D109204

    (cherry picked from commit 217c6d643124be312f4a99b203118744edb9d54c)


Thanks a lot!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210903/d89c679b/attachment-0001.html>


More information about the llvm-bugs mailing list