[llvm-bugs] [Bug 50227] New: [Win][AArch64] Miscompilation in rel-lookup-table-converter-pass

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=50227

            Bug ID: 50227
           Summary: [Win][AArch64] Miscompilation in
                    rel-lookup-table-converter-pass
           Product: clang
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: LLVM Codegen
          Assignee: unassignedclangbugs at nondot.org
          Reporter: Richard.Townsend at arm.com
                CC: llvm-bugs at lists.llvm.org, neeilans at live.com,
                    richard-llvm at metafoo.co.uk

The rel-lookup-table-converter-pass seems to be causing crashing bugs on
Windows on Arm, starting from this commit:

https://github.com/llvm/llvm-project/commit/57b259a852a6383880f5d0875d848420bb3c2945 

This is causing crashes for the electron project [1], also see discussion in
Chromium [2]

[1] https://github.com/electron/electron/issues/28876
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=1204788

blink_unittests.exe!blink::GetNonAliasPropertyInternal(blink::CSSPropertyID id)
Line 2968       C++

Without the new pass:
00007FF7A33F2DFC D00171C9             adrp        x9,string
"gen/third_party/blink/renderer/c"...+20h (07FF7A622C000h)  
00007FF7A33F2E00 51000A68             sub         w8,w19,#2  
00007FF7A33F2E04 91014129             add         x9,x9,#0x50  
00007FF7A33F2E08 B8A8D928             ldrsw       x8,[x9,w8 sxtw #2]  
00007FF7A33F2E0C F9400FE0             ldr         x0,[sp,#0x18]  
00007FF7A33F2E10 8B080133             add         x19,x9,x8  
00007FF7A33F2E14 941717EB             bl          __security_check_cookie
(07FF7A39B8DC0h)  

Without:
00007FF71C8B324C B00171C8             adrp        x8,string "const char
*__cdecl WTF::GetStri"...+10h (07FF71F6EC000h)  
00007FF71C8B3250 91040108             add         x8,x8,#0x100  
00007FF71C8B3254 8B33CD08             add         x8,x8,w19,sxtw #3  
00007FF71C8B3258 F9400FE0             ldr         x0,[sp,#0x18]  
00007FF71C8B325C F85F0113             ldur        x19,[x8,#-0x10]  
00007FF71C8B3260 94171808             bl          __security_check_cookie
(07FF71CE79280h)  

(Reproducer will be uploaded shortly).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210505/a503ab26/attachment.html>