[llvm-bugs] [Bug 49652] New: [RGT] QualTypeNamesTest appears to do nothing

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=49652

            Bug ID: 49652
           Summary: [RGT] QualTypeNamesTest appears to do nothing
           Product: clang
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Frontend
          Assignee: unassignedclangbugs at nondot.org
          Reporter: paul_robinson at playstation.sony.com
                CC: llvm-bugs at lists.llvm.org, neeilans at live.com,
                    richard-llvm at metafoo.co.uk

clang/unittests/Tooling/QualTypeNamesTest.cpp implements a struct
TypeNameVisitor, which is derived from TestVisitor, which appears to be
for tests invoking a RecursiveASTVisitor.

This struct defines a method VisitValueDecl() to do certain tests on
the name of a ValueDecl.  However, that method is never called; I can 
put an 'llvm_unreachable' at the top and it never fires.

The output of running the ToolingTest suggests that QualTypeNamesTest
is actually called, but apparently something about the definition of the
struct and/or its methods keeps the test from ever doing what it looks
like it ought to be doing.

I tried fussing with it a bit (is the parameter not supposed to be const?)
but no simple tweaks made any difference.  I suspect I just didn't find
the right simple tweak, but I've never used these classes myself so I'm
unsure what's missing.


Found by the Rotten Green Tests project.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210319/3cdc053a/attachment.html>