[llvm-bugs] [Bug 49561] New: [RGT] OpenMPIRBuilderTest.cpp missing cases

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=49561

            Bug ID: 49561
           Summary: [RGT] OpenMPIRBuilderTest.cpp missing cases
           Product: libraries
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Core LLVM classes
          Assignee: unassignedbugs at nondot.org
          Reporter: paul_robinson at playstation.sony.com
                CC: llvm-bugs at lists.llvm.org

Three tests in OpenMPIRBuilderTest.cpp are looking for cases that don't happen.
Probably some additional cases should be added? or else the dead checks should
be removed/replaced with assertions.

In test ParallelSimple, the lambda PrivCB is never called with an alloca,
so the code from line 464 to the end of the lambda is dead.

In test ParallelIfCond, the lambda PrivCB is never called with an alloca,
so the code from line 769 to the end of the lambda is dead.

In test ParallelCancelBarrier, the 'if' on line 945:
    if (!isa<ReturnInst>(ExitBB->front())) {
never evaluates to true, i.e. the instruction is always ReturnInst,
so the body of the 'if' is dead.


Found by the Rotten Green Tests project.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210312/d8d0497a/attachment-0001.html>