[llvm-bugs] [Bug 51072] New: Test passes on windows with a ninja build but not a Visual Studio build

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=51072

            Bug ID: 51072
           Summary: Test passes on windows with a ninja build but not a
                    Visual Studio build
           Product: Test Suite
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: lit
          Assignee: unassignedbugs at nondot.org
          Reporter: orlando.hyams at sony.com
                CC: daniel at zuster.org, llvm-bugs at lists.llvm.org

Git revision: main 0da3573a9ef9 (12th July 2021)

The test:
clang/test/utils/update_cc_test_checks/check-globals.test

This test passes on windows when run from a ninja build directory, but not from
a Visual Studio (2017) one. For the Visual Studio build I get this failure:

```
# command stderr:
lit.py: D:\dev\opensource-build-clang\tools\clang\test\lit.site.cfg.py:56:
fatal: unable to find 'build_mode' parameter, use '--param=build_mode=VALUE'
```

Repro steps:
1. Generate build
> cmake <path-to-llvm> -G "Visual Studio 15 2017" -A x64 -Thost=x64 -DLLVM_PARALLEL_LINK_JOBS=1  -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_ENABLE_ASSERTIONS=TRUE

2. Build
3. Run test
> python Release\bin\llvm-lit.py <path-to-llvm>/clang/test/utils/update_cc_test_checks/check-globals.test  -v
<snip>
# command stderr:
lit.py: D:\dev\opensource-build-clang\tools\clang\test\lit.site.cfg.py:56:
fatal: unable to find 'build_mode' parameter, use '--param=build_mode=VALUE'

error: command failed with exit status: 2

--

********************
********************
Failed Tests (1):
  Clang :: utils/update_cc_test_checks/check-globals.test

If I build with ninja instead there is no issue:

1. Generate build
In a "x64 Native Tools Command Prompt for VS 2017" console:
> cmake <path-to-llvm> -G Ninja -DLLVM_PARALLEL_LINK_JOBS=1  -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_ENABLE_ASSERTIONS=TRUE -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER=cl.exe -DCMAKE_C_COMPILER=cl.exe -DCMAKE_ASM_COMPILER=cl.exe -DCMAKE_LINKER=link.exe

2. Build
3. Run test
>python bin\llvm-lit.py <patht-to-llvm>/clang/test/utils/update_cc_test_checks/check-globals.test -v
<snip>
-- Testing: 1 tests, 1 workers --
PASS: Clang :: utils/update_cc_test_checks/check-globals.test (1 of 1)

Testing Time: 3.09s
  Passed: 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210713/9a907e54/attachment.html>