[llvm-bugs] [Bug 49048] New: ".arch_extensions crypto" doesn't work as intended

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=49048

            Bug ID: 49048
           Summary: ".arch_extensions crypto" doesn't work as intended
           Product: libraries
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Backend: AArch64
          Assignee: unassignedbugs at nondot.org
          Reporter: martin at martin.st
                CC: arnaud.degrandmaison at arm.com,
                    llvm-bugs at lists.llvm.org, sander.desmalen at arm.com,
                    smithp352 at googlemail.com, Ties.Stuij at arm.com

When enabling the extension "crypto" via e.g. ".arch armv8-a+crypto", this
enables a number of other extensions, including aes and sha2. When enabling it
via ".arch_extension crypto", these other extensions aren't enabled.

Repro case:

$ cat test.s
.arch_extension crypto
pmull v2.1q, v2.1d, v1.1d
$ aarch64-linux-gnu-as -c test.s
$ clang -target aarch64-linux-gnu -c test.s
test.s:2:1: error: instruction requires: aes
pmull v2.1q, v2.1d, v1.1d
^

While the corresponding case with .arch works fine:

$ cat test2.s
.arch armv8-a+crypto
pmull v2.1q, v2.1d, v1.1d
$ clang -target aarch64-linux-gnu -c test2.s

These other extensions are enabled via the ExpandCryptoAEK [1] function in e.g.
parseDirectiveArch, but that function isn't called in
parseDirectiveArchExtension. It'd be trivial to fix if we'd have a reference to
the AArch64::ArchKind which is in effect - but do we have that somewhere?

[1]
https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp#L5361-L5376

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210204/e4b9374d/attachment.html>