[llvm-bugs] [Bug 51412] New: [clang-format] AlignConsecutiveMacros fights with Visual Studio and resource.h

via llvm-bugs llvm-bugs at lists.llvm.org
Mon Aug 9 04:07:11 PDT 2021


https://bugs.llvm.org/show_bug.cgi?id=51412

            Bug ID: 51412
           Summary: [clang-format] AlignConsecutiveMacros fights with
                    Visual Studio and resource.h
           Product: clang
           Version: unspecified
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: mydeveloperday at gmail.com
                CC: djasper at google.com, klimek at google.com,
                    llvm-bugs at lists.llvm.org

clang-format AlignConsecutiveMacros feature is excellent, but it causes real
problems when using the resource editor in Visual Studio

A resource.h file will be "Align" with an alignment of 40

//{{NO_DEPENDENCIES}}
// Microsoft Visual C++ generated include file.
// Used by MyTest.rc
//
#define IDP_OLE_INIT_FAILED             100
#define IDP_FAILED_TO_CREATE            102
#define ID_STATUSBAR_SHOW               108
#define ID_STATUSBAR_TEXT               109

if it encounters a long symbol it will push it out

#define ID_VERYVERYVERYVERY_LONG_LONG_LONG_LONG_RESOURCE 33221

Every time we make a change in the resource editor in visual studio the
resource.h will be written out (and its not auto clang-formatted)

If you check all files for "clang-formatting" then resource.h will fail
everytime

It would be good to have some AlignConsecutiveMacros options so that
clang-format didn't fight against this format

Some sort of "AlignConsecutiveMacrosMinMaxAlignment: 40"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210809/5431c175/attachment.html>


More information about the llvm-bugs mailing list