[llvm-bugs] [Bug 50144] New: Absolute path of TERMINFO_LIB leaks into exported CMake config

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=50144

            Bug ID: 50144
           Summary: Absolute path of TERMINFO_LIB leaks into exported
                    CMake config
           Product: Build scripts
           Version: trunk
          Hardware: PC
                OS: MacOS X
            Status: NEW
          Severity: normal
          Priority: P
         Component: cmake
          Assignee: unassignedbugs at nondot.org
          Reporter: gjasny at googlemail.com
                CC: llvm-bugs at lists.llvm.org

Hello,

on macOS the exported / installed LLVMExports.cmake file contains the following
absolute path to the curses library:

```
set_target_properties(LLVMSupport PROPERTIES
  INTERFACE_LINK_LIBRARIES
"m;ZLIB::ZLIB;/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/usr/lib/libcurses.tbd;LLVMDemangle"
)
```

This is bad because even with minor Xcode updates the SDK path changes. (e.g.
from MacOSX11.1.sdk to MacOSX11.3.sdk). Instead, linking against "curses" would
be sufficient (like it is done in that line for libm).

The issue has been introduced by:

commit 3c7bfbd6831b2144229734892182d403e46d7baf
Author: Petr Hosek <phosek at google.com>
Date:   Mon Aug 31 15:11:39 2020 -0700
Subject: [CMake] Use find_library for ncurses

Thanks,
Gregor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210427/1990f2ed/attachment.html>