[llvm-bugs] [Bug 49959] New: [Debugify] "Missing line" false alarm on PHI node

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=49959

            Bug ID: 49959
           Summary: [Debugify] "Missing line" false alarm on PHI node
           Product: libraries
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Transformation Utilities
          Assignee: unassignedbugs at nondot.org
          Reporter: yilong.guo at intel.com
                CC: llvm-bugs at lists.llvm.org

debugify always report "missing line" false alarms on PHI node when PHI node is
untouched by the target pass.

Probably relates to https://reviews.llvm.org/D75242

applyDebugifyMetadata adds debug locations on PHI nodes, but
checkDebugifyMetadata unconditionally skips PHI nodes during
missing-line-check.

ll reproducer:
; debugify-ignore-phi.ll
define void @test_phi(i1 %cond) {
0:
  br i1 %cond, label %1, label %2
1:
  br label %2
2:
  %v = phi i32 [ 0, %0 ], [ 1, %1 ]
  ret void
}

opt -disable-output -debugify-each -passes=helloworld debugify-ignore-phi.ll
>> test_phi
>> WARNING: Missing line 3
>> CheckFunctionDebugify [HelloWorldPass]: PASS

I think we should skip PHI nodes for applying debug locations as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210414/7010aa6e/attachment.html>