[llvm-bugs] [Bug 49607] gc.relocate and gc.result should be marked readnone

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Apr 6 08:04:17 PDT 2021


https://bugs.llvm.org/show_bug.cgi?id=49607

listmail at philipreames.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from listmail at philipreames.com ---
Migration complete.  Key change landed two weeks ago without fallout.

commit 4f5e92cc0562629ad2180b3ed2b0dad31ef7797c
Author: Philip Reames <listmail at philipreames.com>
Date:   Thu Mar 25 14:50:07 2021 -0700

    Mark gc.relocate and gc.result as readnone (try 2)

    As noted in the LangRef, these are semantically readnone projections from
the result value of the associated statepoint. However, it turned out we had a
few latent bugs being covered up by the fact we were only marking them readonly
(see PR49607 for context).

    As of this change, all known issues are resolved. This is a deliberately
minimal patch to make it easy to test downstream and revert with minimal change
if that turns out to be necessary.

    Differential Revision: https://reviews.llvm.org/D98729


Removed the bits of code added to make reverts easy:

commit 52ecd94cfbca726aae2532db43aac5dec92ced15 (HEAD -> main, origin/main)
Author: Philip Reames <listmail at philipreames.com>
Date:   Tue Apr 6 07:54:13 2021 -0700

    Remove last remnants of PR49607 migration [NFC]

    The key change (4f5e92c) to switch gc.result and gc.relocate to being
readnone landed nearly two weeks ago, and we haven't seen any fallout.  Time to
remove the code added to make reverting easy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210406/9b58beb0/attachment-0001.html>


More information about the llvm-bugs mailing list