[llvm-bugs] [Bug 48225] [SCEV] computeBackedgeTakenCount() returns incorrect BackedgeTakenInfo

via llvm-bugs llvm-bugs at lists.llvm.org
Mon Nov 23 01:57:08 PST 2020


https://bugs.llvm.org/show_bug.cgi?id=48225

Max Kazantsev <max.kazantsev at azul.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Max Kazantsev <max.kazantsev at azul.com> ---
Fix merged.

commit 48d7cc6ae23b0e5b1922457462d0f6e4582a1ae7
Author: Max Kazantsev <mkazantsev at azul.com>
Date:   Mon Nov 23 16:45:20 2020 +0700

    [SCEV] Fix incorrect treatment of max taken count. PR48225

    SCEV makes a logical mistake when handling EitherMayExit in
    case when both conditions must be met to exit the loop. The
    mistake looks like follows: "if condition `A` fails within at most `X`
first
    iterations, and `B` fails within at most `Y` first iterations, then `A & B`
    fails at most within `min (X, Y)` first iterations". This is wrong, because
    both of them must fail at the same time.

    Simple example illustrating this is following: we have an IV with step 1,
    condition `A` = "IV is even", condition `B` = "IV is odd". Both `A` and `B`
    will fail within first two iterations. But it doesn't mean that both of
them
    will fail within first two first iterations at the same time, which would
mean
    that IV is neither even nor odd at the same time within first 2 iterations.

    We can only do so for known exact BE counts, but not for max.

    Differential Revision: https://reviews.llvm.org/D91942
    Reviewed By: nikic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20201123/6d98ce03/attachment-0001.html>


More information about the llvm-bugs mailing list